[ http://issues.apache.org/jira/browse/WSCOMMONS-24?page=comments#action_12378921 ]
Davanum Srinivas commented on WSCOMMONS-24: ------------------------------------------- Peter, Could u please help us? (with patches?) thanks, dims > Schema "groups" XmlSchemaObjectTable is filled using invalid HashMap keys > ------------------------------------------------------------------------- > > Key: WSCOMMONS-24 > URL: http://issues.apache.org/jira/browse/WSCOMMONS-24 > Project: WS-Commons > Type: Bug > Components: XmlSchema > Environment: WS Commons XML Schema 1.0.2 > Reporter: Peter Hendriks > > The XmlSchemaObjectTable retrieved using XmlSchema.getGroups() is filled in > SchemaBuilder by using the package scope collection variable instead of its > public API. For groups and attribute groups a key of the wrong type is used > (String instead of QName). > As a result groups cannot be accessed using the public API, because you can > only query using a QName, and the keys are only Strings. As a result groups > cannot be read by key and the API is broken. > The issue can be worked around by using the getValues() method to search > through all groups directly. > This should be very easy to fix and I am willing to provide a patch. The code > is riddled with package scoped fields and methods. This is generally bad > practice because of these kinds of problems. Please consider refactoring the > code to more restrictive field/method scoping to have a cleaner API and > prevent errors. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
