[ http://issues.apache.org/jira/browse/WSCOMMONS-21?page=comments#action_12442115 ] Brian Hulse commented on WSCOMMONS-21: --------------------------------------
[[ Old comment, sent by email on Thu, 11 May 2006 12:01:07 +0100 ]] We have a few more tests to contribute in the next day or so, but we do need to open the debate on equals() and I'm not sure how to start this ... in this thread or a new JIRA? I'll start here and maybe we can move it of needed. The question revolves around, when are two Policies equal? There are levels to this, two Policies can be identical ... therefore, obviously equal, but the problem is that the order of Assertions and Operators is not specified and you could imagine a couple of Policies that net out to the same thing, but have all the stuff expressed in a different order. In my book, these Policies are also equal. This is why the test fails, I have 2 biggish WS-SecurityPolicy constructs, that have the same information, but in different orders. It's a tough one, but one way to get a useful equals() method, one would have to net out the Alternatives, order them and them compare like on like. We used hashcodes for each level (Assertions, Alternatives etc.) so we only calculated once, but it's pretty heavyweight ... anyway, comments? Regards, Brian. http://issues.apache.org/jira/browse/WSCOMMONS-21?page=comments#action_123790 59] > Extend WS-Policy tests to encompass more variants (with 3 Assertions) > --------------------------------------------------------------------- > > Key: WSCOMMONS-21 > URL: http://issues.apache.org/jira/browse/WSCOMMONS-21 > Project: WS-Commons > Issue Type: Test > Components: Policy > Reporter: Brian Hulse > Attachments: WS-COMMONS21.zip > > > The interop tests are the bare minimum, you can pass these and still not > fully adhere to the specification. These tests are more realistic. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
