Careless exception handling needs to be fixed
---------------------------------------------
Key: WSCOMMONS-111
URL: http://issues.apache.org/jira/browse/WSCOMMONS-111
Project: WS-Commons
Issue Type: Bug
Components: AXIOM
Reporter: Dennis Sosnoski
org.apache.axiom.om.impl.builder.StAXOMBuilder.next() catches all exceptions
and rethrows them as OMExceptions (line 199) while other code assumes any
OMExceptions just mean that the end of the document has been reached (for
example, org.apache.axiom.om.impl.traverse.next(), line 117, which just sets a
flag). This means that any coding errors which result in runtime exceptions
will be masked.
In the case I've been tracking, an error in
org.apache.axiom.soap.impl.builder.SOAPBuilderHelper.processAttributes (not
checking for a null namespace uri) resulted in a NullPointerException, which
was masked by this code and led to an element being missing from Fault details.
If this code needs to catch particular exceptions these exceptions should be
individually checked. If this is impractical, at an absolute minimum this
should check for a RuntimeException subclass and just rethrow it rather than
masking it as an OMException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
