Hi,

On 11/8/06, Jeehong Min <[EMAIL PROTECTED]> wrote:
Hi Ruchith,

I noticed that you just resolved issue 119, which dealt with namespace
of unqualified attributes.  Issue 114 (which was filed by me) is
directly related to that.  It would be great if you could look at the
issue and resolve it also (I guess this is how I'm voting for the issue
I reported =) ).  For your convenience, I attached a non-junit test case
to the issue.

You obviously are way more familiar with the code than I am, but I think
there may also be a bug in the addAttribute(OMAttribute) function of
OMElementImpl.java.  I don't think it is correctly handling unqualified
("" namespace, "" prefix) attributes.  In my local sources (Axiom
1.1.1), I have:

I think you are correct !

Right now we add the given ns (even though it is unqualified) with a
generated prefix into the list of declared namespaces of the element
where the attr is added. We should not be doing this in the case where
the unqualified OMNamespace instance is from an *attr*.

Chinthaka what do you think?

I will add these comments to the JIRA (WSCOMMONS-114) and upload my
patch to correct this so others can review it as well.

Thanks,
Ruchith

p.s. You can also create an unqualified attribute without providing an
OMNamespace instance as well.

Example:

fac.createOMAttribute("id", null, "2");

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




--
www.ruchith.org

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to