[
https://issues.apache.org/jira/browse/WSCOMMONS-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rich Scheuerle updated WSCOMMONS-179:
-------------------------------------
Attachment: ecblank.gif
pic30745.gif
graycol.gif
Thanks for the explanation. The patch is not completely ready...I am
running into a snag with a couple axis 2 tests. The attachments code is
rather slow in this area and needs improvements.
I might not be able to get to your JAX-WS concern. I am trying to juggle
open source concerns and internal IBM release deadlines. Feeling kinda
squashed right now.
Thanks for your help.
Rich Scheuerle
IBM Web Services
Apache Axis2 ([EMAIL PROTECTED])
512-838-5115 (IBM TL 678-5115)
"Glen Daniels
(JIRA)"
<[EMAIL PROTECTED]> To
R J Scheuerle Jr/Austin/[EMAIL PROTECTED]
03/15/2007 01:37 cc
PM
Subject
[jira] Commented: (WSCOMMONS-179)
Attachment Processing is very
slow...I have a patch that provides
a big speedup
[
https://issues.apache.org/jira/browse/WSCOMMONS-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481276
]
Glen Daniels commented on WSCOMMONS-179:
----------------------------------------
Hi Rich - apologies for any inconvenience, we're in the midst of
reformatting all the code to match our conventions (100 char right margin,
no tab chars, whitespace corrections, etc) and I hit Axiom last week. The
plan is to run the reformatter to clean things up right before each
release, but I did it this time to get a baseline. Didn't mean to step on
your toes there.
speedup
-------------------------------------------------------------------------------
single byte scan.
optimize scanning for bytes....now we do (ByteSearch).
BoundaryDelimittedInputStream and constructed an easy to use ByteSearch
utility.
single byte scans. Please look at this new utility.
search for the boundary. This simplification of design actually
new ByteSearch code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
> Attachment Processing is very slow...I have a patch that provides a big
> speedup
> -------------------------------------------------------------------------------
>
> Key: WSCOMMONS-179
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-179
> Project: WS-Commons
> Issue Type: Improvement
> Components: AXIOM
> Reporter: Rich Scheuerle
> Attachments: ecblank.gif, graycol.gif, patch.txt, patch.txt,
> pic30745.gif
>
>
> This patch "kills 2 slow birds with one stone".
> ---------------------------------------------
> Slow Bird #1: MIMEBodyPartInputStream uses single byte reads.
> Solution: The patch changes MIMEBodyPartInputStream to use byte[] reads.
> ---------------------------------------------
> Slow Bird #2: MIMEBodyPartInputStream looks for the boundary using a single
> byte scan.
> Solution: The root of the problem is that we don't have a utility to
> optimize scanning for bytes....now we do (ByteSearch).
> I hoisted the byte scanning algorithm code out of
> BoundaryDelimittedInputStream and constructed an easy to use ByteSearch
> utility.
> ByteSearch uses a sophisticated "byte skipping" algorithm, which avoids
> single byte scans. Please look at this new utility.
> The second part of the solution is to simply uses the ByteSearch to search
> for the boundary. This simplification of design actually
> cleans up the code AND produces much favorable performance.
> -------------------------------------------------
> Please review the changes. I would like some feedback.
> Follow-on: May consider re-writing ByteDelimittedInputStream to use the new
> ByteSearch code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
