Author: chinthaka
Date: Tue May 8 15:37:45 2007
New Revision: 536362
URL: http://svn.apache.org/viewvc?view=rev&rev=536362
Log:
Fixing WSCommons-202. Text under SOAPFaultDetail element is serialized twice.
Modified:
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultDetailImpl.java
webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/SOAPFaultDetailTest.java
Modified:
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultDetailImpl.java
URL:
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultDetailImpl.java?view=diff&rev=536362&r1=536361&r2=536362
==============================================================================
---
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultDetailImpl.java
(original)
+++
webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultDetailImpl.java
Tue May 8 15:37:45 2007
@@ -79,9 +79,6 @@
getLocalName(),
writer);
- String text = this.getText();
- writer.writeCharacters(text);
-
OMNode child = firstChild;
while (child != null && ((!(child instanceof OMElement)) ||
child.isComplete())) {
((OMNodeImpl) child).internalSerializeAndConsume(writer);
Modified:
webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/SOAPFaultDetailTest.java
URL:
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/SOAPFaultDetailTest.java?view=diff&rev=536362&r1=536361&r2=536362
==============================================================================
---
webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/SOAPFaultDetailTest.java
(original)
+++
webservices/commons/trunk/modules/axiom/modules/axiom-tests/src/test/java/org/apache/axiom/soap/SOAPFaultDetailTest.java
Tue May 8 15:37:45 2007
@@ -16,6 +16,7 @@
package org.apache.axiom.soap;
+import org.apache.axiom.om.OMAbstractFactory;
import org.apache.axiom.om.OMElement;
import org.apache.axiom.om.OMNamespace;
import org.apache.axiom.om.OMText;
@@ -219,5 +220,20 @@
assertTrue(
"SOAP 1.2 Fault Detail Test With Parser : -
getAllDetailEntries method returns an itrator with more than two detail
entries",
!iterator.hasNext());
+ }
+
+ public void testWSCommons202() {
+ SOAPFactory factory = OMAbstractFactory.getSOAP12Factory();
+ SOAPFaultDetail soapFaultDetail = factory.createSOAPFaultDetail();
+ soapFaultDetail.setText("a");
+
+ assertTrue(soapFaultDetail.getText().trim().equals("a"));
+ assertTrue("Text serialization has problems. It had serialized same
text twice", soapFaultDetail.toString().indexOf("aa") == -1);
+
+ OMElement omElement = factory.createOMElement("DummyElement", null);
+ soapFaultDetail.addChild(omElement);
+ omElement.setText("Some text is here");
+
+ assertTrue("Children of SOAP Fault Detail element are not serialized
properly", soapFaultDetail.toString().indexOf("Some text is here") != -1);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
