Some improvements for flexibility!
----------------------------------
Key: WSCOMMONS-257
URL: https://issues.apache.org/jira/browse/WSCOMMONS-257
Project: WS-Commons
Issue Type: Improvement
Components: Policy
Reporter: Ajith Harshana Ranabahu
Assignee: Ajith Harshana Ranabahu
1. The AssertionBuilderFactory is made static inside the PolicyEngine.
It seems this is not flexible since I want to have my own defaults. It
would have been better if we can control this via a System property
but for now I made it a field and added a setter so that one can set a
custom factory
2. The AssertionBuilderFactory need not have any static methods . It
should be an instance inside the PolicyEngine (static right now) and
it has a static registerBuilder method which makes it really ugly.
Actually the static factory instance is never used to register the
builders. So I've made the registerBuilder method an instance
method and also modified the PolicyEngine to rightfully use the static
factory instance. Also moved the static intializer code to the
constructor.
3. The element field in XMLPrimitiveAssertion has a default scope and
is impossible to extend in an outside package. So I've made that a
protected variable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
