[
https://issues.apache.org/jira/browse/WSCOMMONS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592030#action_12592030
]
tmitchell edited comment on WSCOMMONS-325 at 4/29/08 1:02 AM:
-----------------------------------------------------------------
HI Rich,
Thanks for sorting this so quickly. I've built the patch for the
Broker performance people and it looks like, from initial tests, that this
fixes the problem. They are going to run a larger suite of tests to make
sure that it works against multiple scenarios.
I'll let you know when they get back to me about the full test runs.
Thanks again for your help with this.
"Rich Scheuerle (JIRA)" <[EMAIL PROTECTED]>
23/04/2008 19:25
To
Tim J Mitchell/UK/[EMAIL PROTECTED]
cc
Subject
[jira] Resolved: (WSCOMMONS-325)
org.apache.axiom.om.impl.util.OMSerializerUtil.isSetPrefixBeforeStartElement()
doing property lookup on every invocation - performance problem
[
https://issues.apache.org/jira/browse/WSCOMMONS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rich Scheuerle resolved WSCOMMONS-325.
--------------------------------------
Resolution: Fixed
Committed revision 650980.
Tim, please try this out and let me know if you are getting the expected
performance boost.
org.apache.axiom.om.impl.util.OMSerializerUtil.isSetPrefixBeforeStartElement()
doing property lookup on every invocation - performance problem
----------------------------------------------------------------------------------------------------------------------------------------------
org.apache.axiom.om.impl.util.OMSerializerUtil.isSetPrefixBeforeStartElement()
has code that checks for the property
javax.xml.stream.XMLStreamWriter.isSetPrefixBeforeStartElement on the
XMLStreamWriter property that is passed in to the method. We have run
tests that run through this code path and have noticed performance issues
due to the method checking the property on every method invocation.
lookup each time ? And similarly, if the property isn't found, could the
writer.getNamespaceContext() result be cached so that we just do the check
once ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
was (Author: tmitchell):
HI Rich,
Thanks for sorting this so quickly. I've built the patch for the
Broker performance people and it looks like, from initial tests, that this
fixes the problem. They are going to run a larger suite of tests to make
sure that it works against multiple scenarios.
I'll let you know when they get back to me about the full test runs.
Thanks again for your help with this.
Tim Mitchell
Sibus development
MP211
IBM UK Labs, Hursley
tel. no: +44 (0)1962 818879
internal tel. no: 248879
email: [EMAIL PROTECTED]
"Rich Scheuerle (JIRA)" <[EMAIL PROTECTED]>
23/04/2008 19:25
To
Tim J Mitchell/UK/[EMAIL PROTECTED]
cc
Subject
[jira] Resolved: (WSCOMMONS-325)
org.apache.axiom.om.impl.util.OMSerializerUtil.isSetPrefixBeforeStartElement()
doing property lookup on every invocation - performance problem
[
https://issues.apache.org/jira/browse/WSCOMMONS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rich Scheuerle resolved WSCOMMONS-325.
--------------------------------------
Resolution: Fixed
Committed revision 650980.
Tim, please try this out and let me know if you are getting the expected
performance boost.
org.apache.axiom.om.impl.util.OMSerializerUtil.isSetPrefixBeforeStartElement()
doing property lookup on every invocation - performance problem
----------------------------------------------------------------------------------------------------------------------------------------------
org.apache.axiom.om.impl.util.OMSerializerUtil.isSetPrefixBeforeStartElement()
has code that checks for the property
javax.xml.stream.XMLStreamWriter.isSetPrefixBeforeStartElement on the
XMLStreamWriter property that is passed in to the method. We have run
tests that run through this code path and have noticed performance issues
due to the method checking the property on every method invocation.
lookup each time ? And similarly, if the property isn't found, could the
writer.getNamespaceContext() result be cached so that we just do the check
once ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
> org.apache.axiom.om.impl.util.OMSerializerUtil.isSetPrefixBeforeStartElement()
> doing property lookup on every invocation - performance problem
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WSCOMMONS-325
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-325
> Project: WS-Commons
> Issue Type: Bug
> Components: AXIOM
> Reporter: Tim Mitchell
> Assignee: Rich Scheuerle
>
> org.apache.axiom.om.impl.util.OMSerializerUtil.isSetPrefixBeforeStartElement()
> has code that checks for the property
> javax.xml.stream.XMLStreamWriter.isSetPrefixBeforeStartElement on the
> XMLStreamWriter property that is passed in to the method. We have run tests
> that run through this code path and have noticed performance issues due to
> the method checking the property on every method invocation.
> Is there anyway that the value could be cached rather than doing the lookup
> each time ? And similarly, if the property isn't found, could the
> writer.getNamespaceContext() result be cached so that we just do the check
> once ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
