[ 
https://issues.apache.org/jira/browse/WSCOMMONS-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894264#action_12894264
 ] 

Andreas Veithen commented on WSCOMMONS-548:
-------------------------------------------

-1 to the change in its present form. Reasons:

* If the setting is only effective with a thread pool size of 1, then this 
should be enforced.
* There is no documentation (neither code nor user documentation) that clearly 
explains the purpose of this setting.
* It doesn't handle InterruptedException correctly [1].

[1] 
http://today.java.net/pub/a/today/2006/04/06/exception-handling-antipatterns.html#ignoringInterruptedException

> Ability to suspend the JMS polling task for interested amount of time
> ---------------------------------------------------------------------
>
>                 Key: WSCOMMONS-548
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-548
>             Project: WS-Commons
>          Issue Type: Improvement
>          Components: Transport
>            Reporter: Rajika Kumarasiri
>         Attachments: WSCOMMONS-548.patch
>
>
> Currently the polling task of JMS transport will immediately re-try which I 
> think we need to control over in some instance. So I have added a new 
> parameter for the connection factory "transport.jms.TaskSuspendDuration" 
> which can use to specify the time in millisecond that we need to suspend the 
> current polling task. A negative or zero value will not suspend the task. 
> Rajika 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to