Author: veithen
Date: Sat Oct  9 16:57:59 2010
New Revision: 1006192

URL: http://svn.apache.org/viewvc?rev=1006192&view=rev
Log:
WSCOMMONS-556: Modified ElementImpl to avoid creation of the same NamespaceImpl 
instances over and over again. Change suggested by Kasun Gajasinghe.

Modified:
    
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java

Modified: 
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java
URL: 
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java?rev=1006192&r1=1006191&r2=1006192&view=diff
==============================================================================
--- 
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java
 (original)
+++ 
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java
 Sat Oct  9 16:57:59 2010
@@ -73,6 +73,10 @@ public class ElementImpl extends ParentN
 
     private static final EmptyIterator EMPTY_ITERATOR = new EmptyIterator();
 
+    private static final OMNamespace XMLNS_NAMESPACE_WITH_PREFIX = new 
NamespaceImpl(OMConstants.XMLNS_NS_URI, OMConstants.XMLNS_NS_PREFIX);
+    
+    private static final OMNamespace XMLNS_NAMESPACE_WITHOUT_PREFIX = new 
NamespaceImpl(OMConstants.XMLNS_NS_URI, null);
+    
     private static final String INVALID_CHARACTER_ERR = 
"INVALID_CHARACTER_ERR";
     private static final String NO_MODIFICATION_ALLOWED_ERR = 
"NO_MODIFICATION_ALLOWED_ERR";
     private static final String NAMESPACE_ERR = "NAMESPACE_ERR";
@@ -1311,11 +1315,11 @@ public class ElementImpl extends ParentN
                     
                     if ("".equals(prefix)) {
                         AttrImpl attr = new AttrImpl(this.ownerNode, "xmlns", 
ns.getNamespaceURI(), this.factory);
-                        attr.setOMNamespace(new 
NamespaceImpl(OMConstants.XMLNS_NS_URI, null));
+                        attr.setOMNamespace(XMLNS_NAMESPACE_WITHOUT_PREFIX);
                         attributeMap.addItem(attr);
                     } else {
                         AttrImpl attr = new AttrImpl(this.ownerNode, prefix, 
ns.getNamespaceURI(), this.factory);
-                        attr.setOMNamespace(new 
NamespaceImpl(OMConstants.XMLNS_NS_URI, OMConstants.XMLNS_NS_PREFIX));
+                        attr.setOMNamespace(XMLNS_NAMESPACE_WITH_PREFIX);
                         attributeMap.addItem(attr);
                     }
                 }


Reply via email to