Thanks, Mike Good points. I'll make corrections before committing the patch Enjoy your weekend Cheers Oleg
On Fri, 2003-01-31 at 22:43, Michael Becke wrote: > Looks good, nice work. I only noticed a few things, mostly in regard to > formatting, comments. > > - in EntityEnclosingMethod there are a few places when there is an extra > carriage return between the Javadoc comment and the method. > - PostMethod and EntityEnclosingMethod have some unused imports > - the @deprecated message for PostMethod.getParameters() points to > setRequestBody(), but I'm guessing you wanted getRequestBody(). > - EntityEnclosingMethod.setFollowsRedirects() always sets to false. > perhaps a warning should be printed until this can be remedied. > > All tests passed for me. > > Mike > > Kalnichevski, Oleg wrote: > > Bug fixes: > > > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11095 > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11653 > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14731 > > > > Changelog: > > > > - Abstract EntityEnclosingMethod class has been introduced to encapsulate common >behaviour of all entity enclosing methods > > - "Expect: 100-continue" header support > > - HttpClient does not hang indefinitely if the server of origin does not return >status code 100 when expected. HttpClient resumes sending request body after 3 >seconds if no response is sent > > - Support for chunk encoded requests in all entity enclosing methods > > - Entity enclosing methods do not allow automatic redirection > > - More robust (or so I'd like to hope) request content buffering logic > > - PostMethod inherited from EntityEnclosingMethod class > > - PutMethod inherited from EntityEnclosingMethod class > > - Older methods of PostMethod dealing with url-encoded parameters deprecated in >favour of new setRequestBody(NameValuePair[]) method > > > > Feedback, critique appreciated, as always. > > > > Jeff, Mike > > I decided to not touch request body buffering as yet. The patch is getting really >unwieldy. I would like to have it committed, if you confirm it does not break test >cases on your systems. We can deal with smaller issues and improvements incrementally >once the patch has been checked in > > > > Cheers > > > > Oleg > > > > PS: The patch appears to have exceeded the allowed maximum. It has just been >thrown back to me ;-) > > I am afraid I'll have to compress the file > > > > > > ------------------------------------------------------------------------ > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] -- Oleg Kalnichevski <[EMAIL PROTECTED]> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
