DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12798>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12798

Path should not be encoded in HttpMethodBase





------- Additional Comments From [EMAIL PROTECTED]  2003-03-08 23:16 -------
Adrian,

- In fact, the patch does nothing differently compared to what HttpClient does
in its present form. The patch is merely a code clean-up.

- Currently HttpMethodBase#generateRequestLine(...) assumes the query parameter
to be URL encoded and the path parameter to be not URL encoded. This
inconsistency is the essence of the problem, I think

- I tend to prefer the second of your suggestions. I believe that we should just
clearly state in the documentation that URIs or URI elements are assumed to be
URL encoded prior to be passed as input the HttpClient.
HttpMethodBase#setQueryString(NameValuePair[]) and the likes are exceptions from
the rule, which should also be clearly reflected in the documentation.

- URLUtils class should already provide all necessary method needed to URL
encode strings. URL related classes just need to be better documented and
eventually should be spun off into a package of their own.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to