DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21210>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21210 HeaderElement#parse(String) implementation is not optimal ------- Additional Comments From [EMAIL PROTECTED] 2003-07-12 17:32 ------- Hi Oleg, I have just a few minor comments. - There are a few places where methods that return arrays or a list return null. I think they should instead return an empty array or list. e.g. HeaderElement.parseElements(), ParameterParser.parse(). - Header.getValues() is using the newly deprecated HeaderElement.parse(). - There are a number of style violations. Mostly minor stuff like spacing and missing or incorrect javadocs. It's nitpicking but we want to keep that code pretty:) Overall I think this looks good. Nice work as usual. Mike --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
