DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16729>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16729 Allow redirects between hosts and ports ------- Additional Comments From [EMAIL PROTECTED] 2003-07-22 18:52 ------- I REALLY like the way things are shaping up. These are those few comments that I have at the moment * In particular I like the idea of HttpMethodSession (maybe just HttpSession?). I would make an interface out of it, however, as in the future we may give users an option to provide a pluggable custom implementation of the HTTP session. * I would not deprecate 'used' flag as yet. I helps prevent the user from executing the same method multiple times and getting ambiguous results. In the future (3.0) this flag should disappear along with the entire concept of method recycling. * I would pass state & connection manager as HttpMethodSession's constructor parameters. We, then, later may completely do away with those setter methods (setSoTimeout, setConnectionTimeout, setHttpConnectionFactoryTimeout and so on), as I think we should be using a hash map to store HttpClient preferences instead of just keeping on extending APIs with all those numerous options. I'll expand later on this point when we get to discuss the new preferences architecture. * I would also provide Header[] getRequestHeaders(String) at the very least for the sake of API completeness. + if (method instanceof HttpMethodBase) { + return ((HttpMethodBase) method).getMethodRetryHandler(); + } else { + return new DefaultMethodRetryHandler(); + } * IMHO things like that should strongly hint at some design improvements. Do you think there is way doing without that ugly HttpMethodBase cast? I would suggest adding getMethodRetryHandler to HttpMethod interface, if there are no other alternatives Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
