DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16729>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16729 Allow redirects between hosts and ports ------- Additional Comments From [EMAIL PROTECTED] 2003-08-11 21:58 ------- I agree with Oleg: this is really nice. A few comments you can take or leave... * It's a bit ugly that HttpMethodDirectory has to be default-constructed and then have all its properties set with "set" methods, because this means you can get it into an inconsistent state fairly easily. But since it's not an API class, it doesn't matter right now. * As Oleg said, getMethodRetryHandler is disgusting, but you knew that already. :-) Since HttpMethod is a mess and will probably go away in 3.0 (I hope), it's probably OK to leave it this way for now. The retry handler could also go into a configuration object, but that would make it global and I think clients need the flexibility to change it for individual methods. * Should realms and proxyRealms be lazy-allocated? It's probably a premature optimization, but I thought I'd throw it out there. * The CustomHttpConnection example is now using a deprecated ConnectMethod constructor. * TestGetMethodLocal is calling a now-deprecated method on HttpMethodBase * What's the "locked" property on HttpConnection used for? That sort of modality in an object can be confusing. I couldn't find anyone who sets it to true, though. Like I said, it looks good. I don't have any objection to checking it in. * I like what you did with ConnectMethod --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
