DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=28322>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28322 Connection timeout logic redesign ------- Additional Comments From [EMAIL PROTECTED] 2004-04-11 22:35 ------- Hi Oleg, I like the changes. This is definitely the way to go. I have a couple of suggestions. - I think we should change ControllerThreadSocketFactory.createSocket() to accept a SocketFactory and all the other params necessary to create the socket. This way we can hide the SocketTask from external classes. Though we would end up passing in more params I think it would make for a cleaner interface. - We should consider changing ProtocolSocketFactory.createSocket(host, port ... timeout) to accept a HttpConnectionParams instead of a timeout. This will allow for other config params in the future without requiring API changes. - I think ReflectionSocketFactory.createSocket() should be changed to take a SocketFactory instance instead of a socketFactoryName. This is not a major change, but it seems a little cleaner to me. - I suggest we move the bulk of the reflection work from ReflectionSocketFactory.createSocket() to a static initializer. This way we can determine statically whether or not the JVM supports Socket.connect() without testing each time. This may be premature optimization, but my feeling is that it may be worth it. Mike --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
