abstraction is good, abstraction layers are even better...
But seriously: no need for NDC support in HttpClient. My application provides it's own logging framework, so I can use the thread context to pass information from my application to my logging framework, through and without help from the HttpClient layer.
I agree. Abstraction layers can be good, and we already have a logging abstraction layer with commons-logging. With the addition of log4j, a custom filter, and NDC/MDC, logging per thread can be taken care of with no work on the HttpClient end.
What I'd like to think about for 4.0 is to get away from plenty of static loggers in the classes, to dynamic loggers that can be configured differently for different instances of HttpClient. Kind of like the wire log, which also transcends class boundaries. Except that it is still a global wire log, which will combine wire output from different connections and clients. The static class loggers are nice to activate logging for parts of the framework, while leaving it disabled for others. To what degree is this feature used by you and the other developers of HttpClient? On the mailing list, we usually ask people for a wire log, or to switch on logging in general.
We generally don't use the different loggers to filter logging, but they are definitely useful for including some context (i.e. who's doing the logging).
Or maybe it's easier to just include some context in each log message. For example by giving HttpClient instances names, and logging the name each time. ...and giving connections numbers, logging the number each time... this is beginning to sound like an NDC implementation directly in the HttpClient. I better stop now ;-)
Yes, this definitely sounds like NDC plus the current named loggers:)
I think we could definitely do some working in cleaning up logging. The changes Oleg made for the header and content wire logging being an example. We could also try to standardize the log messages.
Before we do anything major though, I think we need to get a better idea of what people are missing in the current system that we can add. What would everyone like to see?
Mike
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
