From: "Hristo Stoyanov" <[EMAIL PROTECTED]>
> James-,
> Do you really care to catch the SQL exceptions
> in the finally{} block? Since doTag(...) permits
> any exceptions to be trown, just let the
> them go up the stack frames. I noticed this
> coding pattern in other tags too.

Good point.

I've modified the code so that it tries to close the statement & result set
as part of normal operation so that closing exceptions will be thrown if
they occur.

> Also, someone else repsonded to these fixes on
> commons-dev, check it out.

Thanks for the heads up - its far to easy to miss things on commons-dev, its
a very busy list.

Have applied a patch for that too, any exception thats thrown and caught are
logged too.
.
James
-------
http://radio.weblogs.com/0112098/

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to