Seems to me that all you need is to add a getParentException method to
your Exception and Throwable to your constructors. Unsure just how much
you're inlining.

Doing all the stuff Lang's exception stuff does seems unnecessary for
Math. Probably nothing new in this opinion :)

Hen


On Thu, 8 Jul 2004, Phil Steitz wrote:

> I agree with both of you.  The patch (though more testing has shown it
> is bugged) tries to bake all functionality of NestableException into
> MathException.  It includes code from NestableDelegate and
> ExceptionUtils as well as NestableException.  The simplest would be to
> copy and rename all of these classes, but I agree with Stephen's
> suggestion that it would be better to just borrow (er... I mean steal)
> the implementation code.  The practical question is do we really need
> all of the functionality in the o.a.c.l.e.Nestable interface?  I am
> travelling now, but when I get back this weekend if there are no
> objections I will commit a fixed version with more and better test cases
> and we can decide what, if anything, we can drop.
>
> Phil
>
>       -----Original Message-----
>       From: J.Pietschmann [mailto:[EMAIL PROTECTED]
>       Sent: Thu 7/8/2004 3:19 AM
>       To: Jakarta Commons Users List
>       Cc:
>       Subject: Re: [math] Eliminating [lang] dependency
>
>
>
>       Mark R. Diggory wrote:
>       > The only other alternative I can think of that may make things easier if
>       > anything changes in the future would be to just copy NestableException
>       > into the math package hierarchy under something like
>       > o.a.c.m.exception.NestableException and extend it from there.
>
>       Given that Java 1.4 Exceptions are nestable and already have
>       most of the features of j.c.l.NestableException, I'd say that
>       getting rid of NestableException is a good idea even at the cost
>       of a significant but temporary code duplication.
>
>       J.Pietschmann
>
>       ---------------------------------------------------------------------
>       To unsubscribe, e-mail: [EMAIL PROTECTED]
>       For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to