Michal Brzozowski <ruso...@poczta.fm> writes:
> http://www.sf.net/projects/litephone

Thanks, here's a list of comments:

1) "Icons in Png directory are under Creative Commons license, created
   by Axialis Team, axialis.com." says README. There are multiple CC
   licenses, which one is this?

1) Same for source code. Even though the sourceforge project page says
   GPL you really should specify the license in the source repository
   too.

3) Would be nice to have at least minimal compilation instruction for
   those who don't have an offline copy of the wiki. Here's a patch:

Index: README
===================================================================
--- README      (revision 12)
+++ README      (working copy)
@@ -1,3 +1,8 @@
-This is the Litephone source distribution. Read 
http://wiki.openmoko.org/wiki/Developing_with_C%2B%2B_and_Qt for compile 
instructions.
+This is the Litephone source distribution. Read 
http://wiki.openmoko.org/wiki/Developing_with_C%2B%2B_and_Qt for compile 
instructions. If you are not cross-compiling you can just

+1) qmake-qt4
+2) make
+
+and then run the ./litephone executable. There is no install target currently.
+
 Icons in Png directory are under Creative Commons license, created by Axialis 
Team, axialis.com.


4) There's no --help: User needs to read the source to discover demo
   and nogsm modes. Consider something like


Index: main.cpp
===================================================================
--- main.cpp    (revision 12)
+++ main.cpp    (working copy)
@@ -6,6 +6,7 @@
 #include <QDateTime>
 #include <QInputDialog>
 #include <QMessageBox>
+#include <iostream>

 #include "logger.h"

@@ -931,7 +932,10 @@
        phone.enableMockGsm();
     else if (argc > 1 && QString(argv[1]) == "nogsm")
        phone.disableGsm();
-    else
+    else if (argc > 1 && QString(argv[1]) == "--help"){
+        std::cout << "usage: litephone [demo|nogsm]" << std::endl;
+        return 0;
+    } else
        phone.enableGsm();

     return a.exec();


_______________________________________________
Openmoko community mailing list
community@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/community

Reply via email to