Sweet, done. I updated the existing tests on user comment indices to match the new URLs.
On Nov 26, 9:38 am, "Bruno Bornsztein" <[EMAIL PROTECTED]> wrote: > Cool! If you can clean it up and get tests to pass, I'd happily merge it in. > > On Wed, Nov 26, 2008 at 3:37 AM, SimianLogic <[EMAIL PROTECTED]>wrote: > > > > > I was poking around with comments in my local branch and made a few > > changes: > > > I added a subroute to the users resource for comments, then test for & > > redirect the Users/username/comments routes to the simpler username/ > > comments. > > > I also made it so empty collections wouldn't bomb out (they were > > rendering a string to screen without a layout, which was pretty > > jarring). The empty comments screen (i.e. yoursite.com/yourname/ > > comments) now has a message to the effect of "No one has commented > > yet" along with the comment box. Likewise, the empty RSS page doesn't > > have any items in it (useful if you post something and want to track > > the comments before someone even comments). > > > I broke a few of the tests in the process, but if there's any interest > > in merging this stuff in the main branch I'll clean it up, push it to > > my github branch, and do a pull request. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "CommunityEngine" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/communityengine?hl=en -~----------~----~----~----~------~----~------~--~---
