Great. I'll work to get my code added tonight or tomorrow. On 2/4/09, jdutil <[email protected]> wrote: > > Well I would like to but i'm having trouble figuring out how to > checkout the branch. If I do the clone i get the master branch every > time and if I switch to the groups branch I can't update to be the > branches code. Can someone help? > > On Feb 4, 6:31 pm, jdutil <[email protected]> wrote: >> Awesome I'm going to take a look at it now. >> >> On Feb 4, 4:19 pm, Bruno Bornsztein <[email protected]> >> wrote: >> >> > Hey y'all, >> > The groups branch is on GitHub: >> >> >http://github.com/bborn/communityengine/tree/groups >> >> > Thanks, >> > Bruno >> >> > On Sun, Feb 1, 2009 at 1:39 PM, Alexis <[email protected]> >> > wrote: >> >> > > Levi, >> >> > > I would have loved to take part in this but I have just emerged from >> > > two eye surgeries for glaucoma and it will be weeks before I can >> > > really work much online. I wish you all the best with this, and really >> > > wish I could participate. Good luck! >> >> > > ~ Alexis >> >> > > On Jan 25, 12:10 pm, Levi Rosol <[email protected]> wrote: >> > > > that's probably the best idea since i am running low on time to put >> > > toward >> > > > this. I'm not sure what we need to do to start a branch in git. >> > > > also, the >> > > > code i'm working with is not on the latest version of rails, so a >> > > > merge >> > > into >> > > > the existing code base will be needed. >> >> > > > if someone could branch the trunk, I can start to merge my changes >> > > > into >> > > it, >> > > > then check in my changes so others can help out. >> >> > > > -- >> > > > Levi Rosol >> > > > Twitter: @LeviRosol >> >> > > > On Sun, Jan 25, 2009 at 12:26 PM, jdutil <[email protected]> wrote: >> >> > > > > Yeah I'm also looking forward to seeing this in CE. I'd love to >> > > > > help >> > > > > with the testing as I try to integrate it into my app. Could you >> > > > > give us an update on how the tests are coming? Perhaps we can get >> > > > > a >> > > > > branch going with groups in it so we could help write the tests if >> > > > > your running into problems. >> >> > > > > On Jan 6, 5:13 pm, Alexis <[email protected]> wrote: >> > > > > > This is great news again, Levi. I hope you had a wonderful >> > > > > > holiday >> > > and >> > > > > > I commend your staying away from code and email. I did much the >> > > > > > same, >> > > > > > but I watched this thread because it is something quite >> > > > > > important to >> > > > > > us. However, we don't want to rush a good thing, just want to >> > > > > > know >> > > how >> > > > > > things are coming along. :-) >> >> > > > > > All the very best, >> > > > > > ~ Alexis >> >> > > > > > On Jan 5, 11:20 am, "Levi Rosol" <[email protected]> wrote: >> >> > > > > > > Alexis- >> >> > > > > > > Sorry it took a while to get back to you (and the group). Took >> > > > > > > some >> > > > > time off >> > > > > > > an tried to stay away from email and code as much as i could. >> > > > > > > :-) >> >> > > > > > > I did spend some time getting a small number of tests in >> > > > > > > place, and >> > > am >> > > > > now >> > > > > > > going to start moving the Group functionality into the CE >> > > > > > > plugin >> > > itself >> > > > > > > (instead of my app). >> >> > > > > > > I'll keep the group posted as i progress. >> >> > > > > > > -- >> > > > > > > Levi Rosol >> > > > > > > Twitter: @LeviRosol >> >> > > > > > > On Fri, Jan 2, 2009 at 10:30 AM, Alexis >> > > > > > > <[email protected] >> >> > > > > wrote: >> >> > > > > > > > Happy New Year, Everyone!!! >> >> > > > > > > > How is the testing forGroupscoming? We are holding our >> > > > > > > > breath, >> > > > > > > > here :-) >> >> > > > > > > > ~ Alexis >> >> > > > > > > > On Dec 15 2008, 7:47 am, "Bruno Bornsztein" >> > > > > > > > <[email protected]> wrote: >> > > > > > > > > More tests = better. >> > > > > > > > > It's very hard for me to add big pieces of functionality >> > > > > > > > > to CE >> > > and >> > > > > make >> > > > > > > > sure >> > > > > > > > > they're bug free without having good test coverage. Last I >> > > checked >> > > > > CE's >> > > > > > > > test >> > > > > > > > > coverage was around 90%, so that's a good number to shoot >> > > > > > > > > for. >> >> > > > > > > > > On Mon, Dec 15, 2008 at 9:45 AM, Carl Fyffe < >> > > [email protected]> >> > > > > > > > wrote: >> >> > > > > > > > > > Where's your test Levi? *chuckle* Hope that helps. >> >> > > > > > > > > > CE is using Test::Unit >> >> > > > > > > > > > On Mon, Dec 15, 2008 at 10:23 AM, Levi Rosol < >> > > > > [email protected]> >> > > > > > > > wrote: >> > > > > > > > > > > good news.groupsnow have all of the functionality a >> > > > > > > > > > > user >> > > would >> > > > > > > > have. >> > > > > > > > > > > membership has been implemented, photos, and comments. >> > > > > > > > > > > I >> > > will >> > > > > spend >> > > > > > > > this >> > > > > > > > > > > week cleaning up a few things, but am planning to move >> > > > > everything >> > > > > > > > that >> > > > > > > > > > > should be in the CE core into the CE plugin and will >> > > > > > > > > > > then >> > > ask >> > > > > for >> > > > > > > > someone >> > > > > > > > > > to >> > > > > > > > > > > help me get the code into the git repos. >> >> > > > > > > > > > > What are the testing requirements for code in this >> > > > > > > > > > > project? >> > > At >> > > > > this >> > > > > > > > > > point, >> > > > > > > > > > > i've written zero tests for the new functionality. >> > > > > > > > > > > partly >> > > due >> > > > > to me >> > > > > > > > > > wanting >> > > > > > > > > > > to use rspec instead of ::test, but mostly because I >> > > > > > > > > > > don;t >> > > have >> > > > > > > > anyone >> > > > > > > > > > > looking over my sholder saying "where's your test at >> > > > > > > > > > > levi?" >> > > > > :-) >> >> > > > > > > > > > > -- >> > > > > > > > > > > Levi Rosol >> > > > > > > > > > > Twitter: @LeviRosol >> >> > > > > > > > > > > On Thu, Dec 11, 2008 at 11:57 AM, Bruno Bornsztein >> > > > > > > > > > > <[email protected]> wrote: >> >> > > > > > > > > > >> You'd need to install git on your machine, sign up >> > > > > > > > > > >> for an >> > > > > account at >> > > > > > > > > > >> github, and push your local repository to github. >> > > > > > > > > > >> There's >> > > a >> > > > > bit of a >> > > > > > > > > > >> learning curve with git, but it's well worth it >> > > > > > > > > > >> (IMO). >> >> > > > > > > > > > >>http://git-scm.com/ >> >> > > > > > > > > > >> On Thu, Dec 11, 2008 at 9:30 AM, Levi Rosol < >> > > > > [email protected]> >> > > > > > > > > > wrote: >> >> > > > > > > > > > >>> What is the process for me adding it to github? I >> > > currently >> > > > > use svn >> > > > > > > > for >> > > > > > > > > > >>> my scm, and won;t be able to open it up for others >> > > > > > > > > > >>> to >> > > use. >> >> > > > > > > > > > >>> I am going to spend some time on it this weekend, >> > > > > > > > > > >>> and >> > > will >> > > > > work to >> > > > > > > > get >> > > > > > > > > > my >> > > > > > > > > > >>> additions moved to the CE plugin folder. There's >> > > > > > > > > > >>> really >> > > no >> > > > > reason >> > > > > > > > for >> > > > > > > > > > these >> > > > > > > > > > >>> to live in my app folder for now. >> >> > > > > > > > > > >>> -- >> > > > > > > > > > >>> Levi Rosol >> > > > > > > > > > >>> Twitter: @LeviRosol >> >> > > > > > > > > > >>> On Thu, Dec 11, 2008 at 8:56 AM, Bruno Bornsztein >> > > > > > > > > > >>> <[email protected]> wrote: >> >> > > > > > > > > > >>>> Hi Levi, >> > > > > > > > > > >>>> I'd be happy to take a look at what you have now, >> > > although >> > > > > the >> > > > > > > > best >> > > > > > > > > > >>>> solution would be for you to put your work up on >> > > > > > > > > > >>>> github >> > > (or >> > > > > some >> > > > > > > > other >> > > > > > > > > > scm) >> > > > > > > > > > >>>> so everyone can have a look. This is for two >> > > > > > > > > > >>>> reasons: >> > > > > > > > > > >>>> 1) If this work is compatible with CE core, I may >> > > > > > > > > > >>>> not >> > > get >> > > > > around >> > > > > > > > to >> > > > > > > > > > >>>> integrating it for a while, someone else might get >> > > > > > > > > > >>>> to it >> > > > > faster >> > > > > > > > > > >>>> 2) Even if it doesn't go into the core, others >> > > > > > > > > > >>>> could use >> > > > > your work >> > > > > > > > as >> > > > > > > > > > a >> > > > > > > > > > >>>> starting point for doing their >> > > > > > > > > > >>>> owngroupsimplementation >> >> > > > > > > > > > >>>> If you're worried about putting your entire app out >> > > there, >> > > > > you >> > > > > > > > could >> > > > > > > > > > >>>> just share the relevant portions. >> >> > > > > > > > > > >>>> Thanks, >> > > > > > > > > > >>>> Bruno >> >> > > > > > > > > > >>>> On Wed, Dec 10, 2008 at 11:09 PM, Levi Rosol < >> > > > > > > > [email protected]> >> > > > > > > > > > >>>> wrote: >> >> > > > > > > > > > >>>>> As of right nowgroupscan be created, a location >> > > assigned, >> > > > > > > > photos >> > > > > > > > > > and >> > > > > > > > > > >>>>> avatars uploaded, and can be searched on by name >> > > > > > > > > > >>>>> and >> > > > > location. >> > > > > > > > > > Activities >> > > > > > > > > > >>>>> are also functional, so you see things like "levi >> > > created a >> > > > > new >> > > > > > > > > > group" in >> > > > > > > > > > >>>>> the "what's fresh" section of your pages. There >> > > > > > > > > > >>>>> are >> > > also >> > > > > > > > grouproles, >> > > > > > > > > > and i >> > > > > > > > > > >>>>> currently have the Owner role functional. >> >> > > > > > > > > > >>>>> My next task is implementing membership >> > > > > > > > > > >>>>> functionality >> > > (and >> > > > > role), >> > > > > > > > > > then >> > > > > > > > > > >>>>> comments. >> >> > > > > > > > > > >>>>> All of this has been kept generic with the intent >> > > > > > > > > > >>>>> of >> > > giving >> > > > > back >> > > > > > > > to >> > > > > > > > > > CE. >> > > > > > > > > > >>>>> However, I'm not confident that i have done this >> > > > > > > > > > >>>>> in the >> > > > > best was >> > > > > > > > for >> > > > > > > > > > the CE >> > > > > > > > > > >>>>> core for a few reasons that i see. First, i'm a >> > > > > > > > > > >>>>> Rails >> > > noob >> > > > > :-) >> > > > > > > > > > because of >> > > > > > > > > > >>>>> this, everything new that I have created has gone >> > > > > > > > > > >>>>> into >> > > my >> > > > > app >> > > > > > > > folder, >> > > > > > > > > > not >> > > > > > > > > > >>>>> the CE plugin. second, I have duplicated many >> > > > > > > > > > >>>>> pieces of >> > > > > > > > > > functionality. For >> > > > > > > > > > >>>>> example, to get photos tied to a group, i >> > > > > > > > > > >>>>> literally >> > > > > copy/pasted >> > > > > > > > the >> > > > > > > > > > photo >> > > > > > > > > > >>>>> model, renamed to groupphoto in my app folder, and >> > > > > esentually did >> > > > > > > > a >> > > > > > > > > > find >> > > > > > > > > > >>>>> replace on user for group. I'm not saying that >> > > > > > > > > > >>>>> this >> > > won't >> > > > > work, >> > > > > > > > > > because it >> > > > > > > > > > >>>>> will, I'm just not personally happy with the code >> > > > > structure. it >> > > > > > > > is >> > > > > > > > > > very very >> > > > > > > > > > >>>>> dirty IMO. Really, it's more un-DRY than dirty. >> >> > > > > > > > > > >>>>> The second reason is, i have no idea how to merge >> > > > > > > > > > >>>>> my >> > > stuff >> > > > > into >> > > > > > > > CE's >> > > > > > > > > > >>>>> git repos. This is probably minor, but it will >> > > > > > > > > > >>>>> require >> > > work >> > > > > on >> > > > > > > > > > bruno's part. >> >> ... >> >> read more ยป > > >
-- Sent from my mobile device -- Levi Rosol Twitter: @LeviRosol --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "CommunityEngine" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/communityengine?hl=en -~----------~----~----~----~------~----~------~--~---
