Are there already tests for helpers in CE? I couldn't find any. If so, please point me there, otherwise and if Bruno is okay with it I will put the test into test/unit/helper/base_helper_test.rb
jak4 On Feb 28, 8:19 pm, Andrei Erdoss <[email protected]> wrote: > I created a ticket for > this:http://communityengine.lighthouseapp.com/projects/11808-communityengi... > > I included the error as a pastie in html. From what I can tell, the empty > @user is being passed to user_url. This object doesn't have an id which is > what causes the user_url function to throw an error. Not 100% what the best > course of action is, but a way to check that the object has an id would > work. > > Andrei > > On Sat, Feb 28, 2009 at 3:52 PM, Bruno Bornsztein < > > > > [email protected]> wrote: > > Nope, this just looks like a regression bug (must not be tested). It'd be > > great if someone could fix it and write a test. If not, please file a bug at > > Lighthouse and I'll get to it when I get a minute. > > Thanks, > > Bruno > > > On Sat, Feb 28, 2009 at 6:42 AM, jak4 <[email protected]> wrote: > > >> This seems to be a rather strange issue, since I'm a 100 % certain it > >> worked and that I didn't change any related code. > > >> When doing a signup that is rejected allowed (username taken, empty > >> password field, etc.) the user will get redirect to the new action. > >> Surprisingly this fails with the following error: > > >> "user_url failed to generate from > >> {:controller=>"users", :action=>"show", :id=>#<User id: nil, login: > >> "", ....." > > >> This can be traced to a line in base_helper.rb/page_title: > >> when 'users' > >> if @user and @user.login > >> title = @user.login > >> title += ', expert in ' + @user.offerings.collect{|o| > >> o.skill.name }.join(', ') if @user.vendor? and [email protected]? > >> title += ' » ' + app_base + tagline > >> �...@canonical_url = user_url(@user) > >> ..... > > >> So what happens is, that the if condition is fulfilled and the code > >> therefore executed. Did I miss some update or whatsoever? This code, > >> as far as I can see, hasn't changed recently (last 2 month). > > >> Regards > >> jak4 > > -- > Andrei Erdoss --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "CommunityEngine" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/communityengine?hl=en -~----------~----~----~----~------~----~------~--~---
