Steve,

Looks mainly okay to me, just a very minor comment (which you left just 
to catch me out :-) ) ...

Paul

Steven M. Christensen wrote:

> This is a code review request for the update of the SFWnmh package to 
> version 1.3.
> 
> The webrev is at
> 
> http://companion.sunfreeware.com/downloads/nmhwebrev/
> 
> Details:
> 
> 1. Update of source code file.
> 2. Version number changes in METADATA, install-sfw, Makefile.sfw, and
>    pkginfo.tmpl
> 3. Copyright year updated where needed.
> 4. Several files moved or deleted with changes from 1.2 to 1.3.
> 
> This builds cleanly in Nevada, the package installs properly, and 
> produces a working set of programs.

=== Start of Comments ===

1. src/pkgdefs/SFWnmh/prototype_com
    Copyright year is wrong

2. src/cmd/nmh/Makefile.sfw
    Format of copyright line - remove '(c)'

=== End of Comments =====
-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products

Reply via email to