Steve, It all looks okay, but see below for a comment ...
Paul Steve Christensen wrote: > This is a code review request for the update of the SFWsquid package to > version 2.7.STABLE5. The webrev is at > > http://companion.sunfreeware.com/downloads/squidwebrev/ > > Details: > > 1. Source code file updated. > 2. METADATA file added. > 3. Version numbers updated. > 4. Copyright dates updated. > 5. SCCS ids removed. > 6. RunAccel script removed in install-sfw and prototype_com. > 7. Locations of RunCache and cachemgr.cgi moved in install-sfw. > > This produces a working build and package. > > This package is only for use in future Solaris 10 CCD updates. === Start of Comments === 1. src/cmd/squid/METADATA Looks okay to me, but I'm just wondering if this should really be the same format as that used for sfwnv now, ie. that in .. "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
