Paul - Thanks for the suggestion. I have added a README.SFWxterm file with some comments about the startup message xterm gives and added the appropriate changes to Makefile.sfw and prototype_com so that this file installs in the usual place. The new webrev is at
http://companion.sunfreeware.com/downloads/xtermwebrev/ Let me know if this is OK. Steve C. > Just the one comment, see below: otherwise it looks > okay to me > > I have not preference on how you deal with the "known > issue", but maybe > whatever you do should be put in README.SFWxterm. > > Paul > > ===== Comments ====================== > > 1. src/cmd/xterm/uxterm.patch > is the XTERM_PROGRAM= /usr path correct? > == End comments ================== > > > Steve Christensen wrote: > > This is a code review request for the update of the > xterm Companion package from version 229 to version > 234 (the current version). > > > > The webrev is at > > > > > http://companion.sunfreeware.com/downloads/xtermwebrev > / > > > > Details: > > > > 1. Source file updated to version 234. > > 2. METADATA file updated. > > 3. Copyright year updated where needed. > > 4. SCCS ids removed. > > 5. Version numbers updated in Makefile.sfw, > install-sfw, pkginfo.tmpl files. > > 6. resize patch no longer needed so it has been > removed and its use in Makefile.sfw removed. > > 7. menu-include.patch updated and expanded to > include more changes of menu.h locations. > > 8. uxterm.patch updated to correspond to new uxterm > file. > > > > The new code builds cleanly on NV 84 and a pkgadd > creates a working xterm. > > > > One issue that might still need to be addressed is > that when xterm is started, the following > > message appears - > > > > input method doesn't support my preedit type > (OverTheSpot,Root) > > > > This is a known issue with xterm and can be dealt > with in three ways > > > > 1. Ignore it as it does not affect the use of > xterm. > > 2. Recompile xterm with --disable-i18n. > > 3. The xterm FAQ says that when this message > appears - > > > > input method doesn't support my preedit type > > Ignore this if you do not know what input > method is. Input methods are used to enter composite > characters (e.g., umlauts, other types of punctuated > characters, East Asian characters, etc). Your > computer's libraries support this, but are missing > configuration tables, and xterm is warning you. > > > > If the message bothers you (e.g., if you aren't > starting xterm from a window manager menu), you can > suppress it by setting a resource: > > > > > > XTerm*openIm:false > > > > > > I am open to suggestions on what solution to use. > > > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion > -discuss -- This messages posted from opensolaris.org
