Steve,

A few comments, see below; other than those it looks okay to me. ...

Paul
On Tue, 2008-07-08 at 12:22, Steve Christensen wrote:
> This is a code review request for the update of the SFWaalib package to 
> version 1.4rc5.
> 
> The webrev is at
> 
> http://companion.sunfreeware.com/downloads/aalibwebrev/
> 
> Main Details:
> 
> 1. Update source code file.
> 2. Update copyrights.
> 3. Added METADATA file.
> 4. Minor patch to one file so that the proper aalib.h file is found.
> 5. Version numbers updated where needed.
> 6. install-sfw and prototype_com files updated with new libraries and man 
> pages.
> 
> Builds properly in a nightly on NV87.

=== Start of comments ===

1. src/lib/aalib/install-sfw
   Could you have used '_install ? ...' instead if the multiply
   lines, rm/cp/chmod ?

   You seem to have remove the 'Copyright' lines completely

=== End of comments =====

Reply via email to