--- Steve Christensen <steve at smc.vnet.net> wrote: > Paul - > > Actually all the changes were made to the files in > 2007 so I did not > do 2008. I presume it is OK to leave them at 2007.
It's okay with me (hence 'very minor comment'), but in terms of the 'gate' the the change will be made in 2008. But feel free to ignore as its only cosmetic anyway :-) Paul > > paulcun at talk21.com wrote: > > Steve, > > > > This looks okay to me - very minor comment: the > > "Copyright" year needs updating to 2008 in lots of > the > > changed files. > > > > Paul > > > > --- Steve Christensen <sunfreeware at gmail.com> > wrote: > > > >> This is a resubmission of a code review request > for > >> the updates of the SFWtclx (tclx) and > >> SFWexpect (expect) packages. Note that expect > will > >> shortly be part of Nevada and will then be > >> removed from the Companion. For now, the update > was > >> done so that a full nightly build could > >> be finished. > >> > >> Tcl and Tk source directories are added as both > tclx > >> and expect need the > >> source to build. > >> > >> The webrev is at > >> > >> > > > http://companion.sunfreeware.com/downloads/tclxexpectwebrev/ > >> Details - > >> > >> 1. Source code files updated. > >> 2. METADATA files added. > >> 3. The Tcl and Tk directories are there only to > >> supply source code availability. > >> 4. Version numbers and Copyrights updated where > >> needed. > >> 5. ./configure options modified to point to the > >> correct tcl and tk source directories. > >> 6. prototype_com and pkginfo.tmpl modified with > new > >> files and directories. > >> 7. Various patches removed that are no longer > needed > >> and new patch created. > >> 8. Targetdirs and Makefiles updated to deal with > tcl > >> and tk source directories and tclx directories. > >> > >> This builds with no problems or errors on NV 76. > >> > >> Steve Christensen > >> -- > >> This messages posted from opensolaris.org > >> _______________________________________________ > >> companion-discuss mailing list > >> companion-discuss at opensolaris.org > >> > > > http://mail.opensolaris.org/mailman/listinfo/companion-discuss > > > > >
