Hi,
I just had a look at the old beryl plugin tree and found out that it
originally was "imagemime:image/png" (for using mime types as
identification) and "imageext:png" (of file extension identification).
While porting the features to metadata "imagemime" has become
"imageext" (probably just a little c&p mistake).
So actually it makes sense to have a mime-type and extension identification.
I attached an updated patch which should fix the typo.
Cheers,
Patrick
2007/7/12, David Reveman <[EMAIL PROTECTED]>:
On Wed, 2007-06-13 at 19:01 +0200, Patrick Niklaus wrote:
> I just found out that the old specification for this were
> "imageext:..." so I attached a new patch to use this instead. Also I
> fixed my indention to use compiz style.
>
> Regards,
> Patrick
>
> 2007/6/13, Patrick Niklaus <[EMAIL PROTECTED]>:
> > Hi,
> > I just noticed that the current image loader plugins such as PNG, SVG
> > and JPEG don't provide a feature as they used to do. This is needed
> > for conflict checking and feature testing (e.g. by the settings
> > manager). If I remember correctly this plugins had features before the
> > metadata port so I did a patch to add them again.
> > What do you think about that?
> >
> > Regards,
> > Patrick
> >
> >
Why both
+ <feature>imageext:png</feature>
and
+ <feature>imageext:image/png</feature>
?
Backward compatibility? In which case it might make sense to abandon the
old way as the configuration utility needs to be updated to fetch the
feature from the metadata anyhow.
-David
diff --git a/metadata/png.xml.in b/metadata/png.xml.in
index b8e516b..c4ccab3 100644
--- a/metadata/png.xml.in
+++ b/metadata/png.xml.in
@@ -2,5 +2,7 @@
<plugin name="png">
<_short>Png</_short>
<_long>Png image loader</_long>
+ <feature>imageext:png</feature>
+ <feature>imagemime:image/png</feature>
</plugin>
</compiz>
diff --git a/metadata/svg.xml.in b/metadata/svg.xml.in
index 63c53b6..9442ff0 100644
--- a/metadata/svg.xml.in
+++ b/metadata/svg.xml.in
@@ -3,5 +3,7 @@
<plugin name="svg">
<_short>Svg</_short>
<_long>Svg image loader</_long>
+ <feature>imageext:svg</feature>
+ <feature>imagemime:image/svg+xml</feature>
</plugin>
</compiz>
_______________________________________________
compiz mailing list
compiz@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/compiz
