On Tue, Jun 05, 2007 at 02:41:59PM -0400, David Reveman wrote: > On Tue, 2007-06-05 at 00:17 +0300, Daniel Stone wrote: > > On Mon, Jun 04, 2007 at 05:06:20PM -0400, David Reveman wrote: > > > Yea, I forgot about that. Will the attached patch work or are those > > > device events not using the keyButtonPointer structure? > > > > Unfortunately, they're not using keyButtonPointer, and you can't put it > > in a case, as the event numbers are non-constant. They use > > deviceKeyButtonPointer, but you also need to check deviceValuator. See > > dix/getevents.c, and mi/mieq.c. > > I've adjusted the patch for deviceKeyButtonPointer. Like in my previous > patch, device events are checked for in the default so that they are not > constant should already be handled fine. Not sure exactly what to do > about deviceValuator events yet.
Looks good to me. I can't remember if you get all the events stacked together by the time WriteEventsToClient comes around, or if you get them individually. If the latter, you need to keep a cache -- ugh. If the former, then it becomes pretty easy. Cheers, Daniel
signature.asc
Description: Digital signature
_______________________________________________ compiz mailing list compiz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/compiz
