Sounds great! I didn't know of that EWMH notation, sorry. About zoom plugin we made it compatible with plane, if you want I can port it to compiz soon, or you can just check the diff here : http://bugs.beryl-project.org/changeset/551
The non fatal dependency reason sounds sensible, okay! I think we could use these features informations in core, to improve functionnality or performances. Please note that I really appreciate this, and I'll go on contributing. I think such problems & solutions should be discussed like that. Hopefully I will be able to help with the multi device issues. Thanks! Regards, Guillaume Seguin 2006/10/9, David Reveman <[EMAIL PROTECTED]>:
Great, I did some minor changes and pushed this out. I called the cube/plane feature "largedesktop" instead of "extendedDesktop" as this is how EWMH refers to this feature. Zoom plugin currently require this feature but I'm going to updated it so it doesn't sometime soon as there's no reason why you shouldn't be able to use it without a "largedesktop" feature active. Decorator plugin now provides a "decorations" feature. I'll keep the "due to dependency problems" fprintf for now as the first fprintf will tell you that there was a dependency problem and this second one will tell you that it couldn't activate the plugin due to it. We might have non-fatal dependency problems later on.. Thanks, -David On Sun, 2006-10-08 at 01:12 +0200, Guillaume wrote: > Greetings, > > Here's my implementation of your great idea. It adds > CompPluginRuleRequire, that allows a plugin to depend on a feature, > and two items in the plugin VTable, features and nFeatures. I know I > could have merged the features and the dependencies systems, but it > looks much cleaner (a feature is not actually a dep). > Plugins have been modified consequently (adding the new VTable items), > and Cube, Plane and Zoom plugins now use the new Features code. > I did my best to follow your coding style and indentation guidelines, > hopefully it'll fit your requirements. > As a side note, I'd suggest removing the "Can't activate plugin due to > dependency problems" fprintf, since it's just repeating the error > already printed in checkPluginDeps function. > > Regards, > Guillaume Seguin >
_______________________________________________ compiz mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/compiz
