Kore Nordmann wrote: > On Wed, 2007-08-08 at 13:26 +0200, Alexandru Stanoi wrote: >> Kore Nordmann wrote: >>> Hi, >>> >>> From the requirements document discussed earlier I created the design >>> document for the multiple axis feature in ezcGraph. You can find it in >>> SVN [1] and attached to this mail. >>> >>> No big deal in the document - more or less the only thing to chose about >>> are the property names. Everything else seems to be natural deduction >>> from the design of ezcGraph. >>> >>> :: >>> >>> $marker = new ezcGraphChartElementLabeledAxis(); >>> $marker->position = ezcGraph::LEFT; >>> $marker->chartPosition = .4; >>> >>> $chart->additionalAxis[] = $marker; >>> >>> The property $position is already used by ezcGraphChartElement to indicate >>> the >>> overall position and accepts bitmasks of LEFT, RIGHT, BOTTOM and TOP. For >>> Axis >>> this indicates the base point of the axis and for additional axis it will >>> define wheather the new axis is an X or Y axis in the cartesian coordinate >>> system of bar and line charts. >>> >>> As the property $position is already used the property $chartPosition >>> indicates the position of the axis in the charts data section. A value of 1 >>> will place the axis at the very end, and a value of 0 at the very beginning >>> of >>> the data. >>> >>> In the example above ezcGraph::LEFT means that the axis is drawn from the >>> left >>> to the right, so it is an additional x axis, and the $chartPosition >>> indicates >>> the position at 40% of the chart data bounding height. >> Does it sound better to say HORIZONTAL to specify the X axis, instead of >> LEFT? >> >> It's a little confusing in my opinion to say LEFT and to mean "left to >> right". > > You may want to specify the direction of the axis (from right to left). > And this is already done this way since the very first revision. As > HORIZONTAL is already used somewhere else we can't make it an alias, but > if you like another name for it I could create an constant alias for it.
If this is the same since the first revision then I have no objection. I don't know exactly what is a constant alias, but I guess you shouldn't do it just for this small issue with naming. -- Alexandru Stanoi eZ Components System Developer eZ Systems | http://ez.no -- Components mailing list [email protected] http://lists.ez.no/mailman/listinfo/components
