Derick Rethans wrote: > On Mon, 6 Aug 2007, Derick Rethans wrote: > >> On Mon, 6 Aug 2007, Raymond Bosman wrote: >> >>> On Sunday 05 August 2007 16:46, Felix Weis wrote: >>>> I've created a patch for my bug #11228 >>>> (http://issues.ez.no/IssueView.php?Id=11228&ProjectId=1) which didnt allow >>>> an absolute windows-path (C:\...\template.ezt) as template location. >>>> >>>> Here's a quick fix for the issue, created against trunk. >>> Thanks for the patch! I am just thinking if: >>> >>> - There is a PHP function for this. >> As far as I know there isn't any for this, but it would be a good idea >> to add this to ezcBaseFeatures as a method. > > I've discussed this (briefly) with Raymond, and it would of course > better fit in the File component. However, if we do that we'd need to > make Template (and perhaps others later as well) dependent on File which > I don't really like as we strive for as little depencies as possible. So > I see a few options here: > > 1. Do it in the Template component - as for now we only need it there > really. > 2. Add a method to the ezcFile class in the File component, and make > Template depend on File. > 3. Move the ezcFile class to the Base package, and implement the new > method there - this will result in some problems as then people > *have* to upgrade both File and Base at the same time to prevent > duplicate autoload files / class names. > > So for now I would go with the first solution, what do you all think?
I would prefer option 1. But I have some thoughts about the 3rd option. For me it's a little confusing that the exceptions for missing/unreadable/unwritable files are in Base instead of File. The File component doesn't do much, it just has a findRecursive() method and some other similar ones. Maybe a merging of File and Base would be possible? But that would make Base be bigger, something which contradicts with the initial design of Base? Some other functionalities could be implemented in Base/File, like creating temporary directories and registering deletion of files at shutdown (which is done in Mail). -- Alexandru Stanoi eZ Components System Developer eZ Systems | http://ez.no -- Components mailing list [email protected] http://lists.ez.no/mailman/listinfo/components
