Hi,

is there a chance to see the subSelect() method from ezcQuerySelect to be moved to ezcQuery?

I've a attached a patch againt eZ Components 2007.1.1 with a few simple changes. The changes in ezcQuerySubSelect address bug #010783. I'm not really sure what the original code intends to do, as it is very likely that ezcQuery::$expr is null or at least not of type ezcQueryExpression (which is an assumption made by the rest of the code). Although this solution isn't perfect either I think it is an passable approach. To avoid error-proneness one would have to ensure that ezcQuery::$expr is always of type ezcQueryExpression.


Sincerly yours,
Julian Reich

BTW: The same goes for ezcQuery::__construct(). Unless I missed something the condition $this->expr == null will always hold.

Attachment: ezc-subselect.patch
Description: Binary data

-- 
Components mailing list
[email protected]
http://lists.ez.no/mailman/listinfo/components

Reply via email to