Thomas Nunninger wrote: > Hi, > > is_null, as we didn't manage to chat directly in IRC on weekend, I post > my questions related to your design draft > (http://rafb.net/p/VLt8Wm42.html) here on the list... > > The questions are about your example code: > >> // ezcMvcUrlUserInputTieinRequestParser implements >> // ezcMvcRequestParserInterface >> $parser = new ezcMvcUrlUserInputTieinRequestParser(); >> >> // The parser returns an instance of ezcMvcInput. >> $input = $parser->getInput(); >> >> // ezcMvcUrlUserInputTieinRouter implements ezcMvcRouterInterface >> $router = new ezcMvcUrlUserInputTieinRouter( $input ); >> >> // An array of routers >> $controllers = $router->getControllers(); >> // For example, an instance of ezcMvcTemplateTieinHtmlViewManager >> $viewManager = $router->getViewManager(); >> >> foreach( $controllers as $controller ) >> { >> $viewManager->appendOutput( $controller->run( $input ) ); >> } >> >> // Creates the response and sends it to the client. >> $viewManager->handle();
I didn't read the design document (the link doesn't work), but I have a suggestion for the above example: the class names does not need to contain "Tiein". As I see it, a Tiein component is just a container for classes which use 2 or more components. So these class names could be used instead of the ones in the example: ezcMvcUrlRequestParser, ezcMvcUrlRouter, ezcMvcHtmlViewManager (or similar to those). Shorter is nicer. :) Another thing: I thought "Interface" should not be part of class names (see ezcMvcRouterInterface and ezcMvcRequestParserInterface). -- Alexandru Stanoi eZ Components System Developer eZ Systems | http://ez.no -- Components mailing list [email protected] http://lists.ez.no/mailman/listinfo/components
