Hei, I've some comments to this as well.
On Wed, 7 May 2008, Alexandru Stanoi wrote: > - Huge docblock at the beginning of the file is annoying. We should think > about a way to include docs there. > + > +# I prefer to write longer docblocks to help a bit the people who want to > jump > + in without reading the tutorial first or asking on IRC. I agree here, the classes' doc blocks should be informative. Some of the current ones in many components are quite useles as they don't really help the users to understand how to use a class. For the @mainclass classes, they should have a thorough overview including examples. > - ezcFeedTools::getAttributes() is a duplication of > DOMElement::getAttribute(). > + > +# I must have missed that. I will deprecate the function. Instead of deprecating, can't you just remove it? We've never released Feed as stable, so we can change the API as much as we want still. > - ezcFeedTools::prepareDate() should not accept DateTime objects. If it > receives them, this indicates bad code. > + > +# What if you assign a DateTime object to $feed->published for example? > Should > + the code throw an exception because the date was not a string or timestamp? DateTime objects should be supported here. How is it bad code if it receives them? regards, Derick -- Components mailing list [email protected] http://lists.ez.no/mailman/listinfo/components
