Hi Benjamin, On 06/02/2009 12:29 AM Benjamin Eberlei wrote:
> i took some time on the weekend to dive into the identity map implementation > of the upcoming ezc release. I have to say its an awesome solution given the > technical difficulties that the current implementation of relations puts on > an > identity map. Thumbs up Toby :-) Thanks a lot, testing that stuff is highly appreciated and getting feedback even more. <snip /> > A minor detail that i didn't like so much is the code-duplication of identity > map decorator and the load handler, which is difficult to eliminate due to > both > of them being "far away" in the package structure. > > But considering that the 3 handlers have only been created to simplify the > persistent object manager they still belong together somehow. Maybe it is > time > to abstract'ize the loader (possible the save and delete handler too) and > make > the identity map decorator have one implementation also that removes code > duplication. Abstract handlers have the advantage that they help in the > further development of PO with new features. Could you elaborate a bit more on how this could happen? I still don't get the main point. Not sure if we could realize such changes for 2009.1, since we are already looking forward to a beta release. Thanks a lot for your feedback, Toby -- Mit freundlichen Grüßen / Med vennlig hilsen / With kind regards Tobias Schlitt (GPG: 0xC462BC14) eZ Components Developer t...@ez.no | eZ Systems AS | ez.no -- Components mailing list Components@lists.ez.no http://lists.ez.no/mailman/listinfo/components
