Stephen Warren wrote: > Phil Dibowitz wrote: >> One comment on ** vs *&. The code tends to use *& in any non-public API, and >> ** only for public functions since C requires that. You converted various >> private APIs to **, and I prefer to leave them *& to be consistent with the >> entire rest of the codebase. Only the actual libconcord.h API gets **, and >> that header file is in fact the dividing line. So I'd like that reversed. > > But but you let me get away with it for GetTag :-) :-) > > Anyway, I've reverted those changes.
Well, you reverted MOST of them. I reverted GetTag for you. > See attached. After changing GetTag() and a few spacing issues, I applied your patch. Thanks! -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
