I built libconcord under Windows in preparation for testing congruity there, and found some issues. Attached are the fixes:

1) When I changed libconcord.h, I didn't update the Windows .def file. The attached concordance-win-def.patch does this.

2) Marco should comment on this:

Both libconcord_winhid and concordance (and possibly other Window projects I didn't build) attempt to link against odbc32.lib and odbccp32.lib. I don't have either of these in Visual C++ Express 2005. So, I removed them from the link line, and everything appears to link fine (have not tested execution yet). Hopefully, these libraries are there just because default projects are set up this way? Since ODBC is a database access library, I can't see why libconcord would need it... See attached concordance-win-odbc.patch (which should probably be expanded to the other vcproj files too)
Index: concordance/win/concordance.vcproj
===================================================================
RCS file: /cvsroot/concordance/concordance/concordance/win/concordance.vcproj,v
retrieving revision 1.4
diff -u -p -r1.4 concordance.vcproj
--- concordance/win/concordance.vcproj  26 Mar 2008 01:30:46 -0000      1.4
+++ concordance/win/concordance.vcproj  30 Mar 2008 06:32:11 -0000
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="Windows-1252"?>
 <VisualStudioProject
        ProjectType="Visual C++"
-       Version="8,00"
+       Version="8.00"
        Name="concordance"
        ProjectGUID="{472FC1A1-C379-4F65-AFD1-41996F052726}"
        >
@@ -160,7 +160,7 @@
                        />
                        <Tool
                                Name="VCLinkerTool"
-                               AdditionalDependencies="./Debug/libconcord.lib 
ws2_32.lib odbc32.lib odbccp32.lib"
+                               AdditionalDependencies="./Debug/libconcord.lib 
ws2_32.lib"
                                OutputFile=".\Debug/concordance.exe"
                                LinkIncremental="2"
                                SuppressStartupBanner="true"
Index: libconcord/win/libconcord_winhid.vcproj
===================================================================
RCS file: 
/cvsroot/concordance/concordance/libconcord/win/libconcord_winhid.vcproj,v
retrieving revision 1.4
diff -u -p -r1.4 libconcord_winhid.vcproj
--- libconcord/win/libconcord_winhid.vcproj     26 Mar 2008 01:30:46 -0000      
1.4
+++ libconcord/win/libconcord_winhid.vcproj     30 Mar 2008 06:32:12 -0000
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="Windows-1252"?>
 <VisualStudioProject
        ProjectType="Visual C++"
-       Version="8,00"
+       Version="8.00"
        Name="libconcord_winhid"
        ProjectGUID="{0665485E-2249-4FD8-BE9C-CCC0C3BBF3A8}"
        >
@@ -72,7 +72,7 @@
                        />
                        <Tool
                                Name="VCLinkerTool"
-                               AdditionalDependencies="ws2_32.lib odbc32.lib 
odbccp32.lib"
+                               AdditionalDependencies="ws2_32.lib "
                                
OutputFile="Debug/libconcord_winhid/libconcord.dll"
                                LinkIncremental="2"
                                SuppressStartupBanner="true"
Index: libconcord/win/libconcord.def
===================================================================
RCS file: /cvsroot/concordance/concordance/libconcord/win/libconcord.def,v
retrieving revision 1.5
diff -u -p -r1.5 libconcord.def
--- libconcord/win/libconcord.def       14 Mar 2008 05:01:26 -0000      1.5
+++ libconcord/win/libconcord.def       30 Mar 2008 06:32:12 -0000
@@ -68,11 +68,9 @@ read_config_from_remote
 write_config_to_remote
 read_config_from_file
 write_config_to_file
-verify_xml_config
 verify_remote_config
 erase_config
-find_config_binary_size
-find_config_binary_start
+find_config_binary
 
 ; SAFEMODE FIRMWARE INTERACTIONS
 ;
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to