Phil Dibowitz wrote: > Phil Dibowitz wrote: >> Phil Dibowitz wrote: >>>> Your code flow suggestions sound good. >>> I was actually going to nuke all of the read_*_from_file garbage when I got >>> the patch to abstract that out - I'm still planning on doing that in the >>> next day or so, so if you want you can just concentrate on porting your >>> identify_file API. >> Oh - I don't think I was clear here - when I do that I was also planning on >> changing the code flow as suggested... > > This is now done and in CVS. Once you've implemented your filetype detection > you should need minimal change to make concordance use it. Nuke > detect_mode() and replace the call to it with a call to your new libconcord > function. Then set mode based on the response and done.
Incase anyone is interested here's the diffstat from the patch - the histogram is pretty interesting to see where code was added/removed: concordance.c | 196 +++++++++++++++++++++++++++++---------------------------- libconcord.cpp | 50 ++++---------- libconcord.def | 4 - libconcord.h | 26 +------ web.cpp | 2 5 files changed, 124 insertions(+), 154 deletions(-) -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
