Phil Dibowitz wrote: > Stephen Warren wrote: >> Phil Dibowitz wrote: >>> ... >>> So I plan to switch this. Everywhere a USB message is constructed I'll NOT >>> include the extra 0-byte and then I'll ADD a 0-byte in the Windows code. >>> >>> Does anyone have any objections to this or concerns? >> Sounds like a great idea to me - I was a little confused by the extra >> bytes at first. > > Wow, that got a bit messy in parts. Here's a patch. It works for me for all > actions, but I'd like a bit more testing before I commit it. > > In particular, I need windows testing since I don't even know if my Windows > code here compiles (I don't have any of the APIs to even attempt). > > This does the aforementioned conversion and also cleans up most of the style > issues with winhid.cpp.
I'm out of town this weekend, so don't expect much from me until next week, but I'd *really* like to get someone to test this patch in Windows and another Linux tester, if at all possible. -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
