Stephen Warren wrote: > Phil Dibowitz wrote: >> FYI: I get the feeling that unistd.h may not be available on Windows - so >> someone may want to test that and let me know... > > Well, the attached patch fixes the compile failure.
Looks solid. > This can be solved by adding a calling to get_identity within the > wait-for-reset loop. This actually does touch HW on Windows, and hence > fails, which can be made to force the loop to loop instead of exit. We should probably do a get_identity() anyway to fill in any data. We shouldn't return from upload_config() with less data then when we went in. I'll fix that (it sounded like you meant to, but it wasn't in your patch). > However, I figure we should instead fix FindRemote to only find > actually-attached remotes. I'm trying to look into this, but it's not a > 5-minute fix. We should do both. If you can figure out how to do this, I'm all for it. -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel