Andreas Schulz wrote: > Eventually, I hope that I got most of Phil's and Stephen's remarks into this > patch. Patch is against the current CVS status (as of 2008-10-10).
Applied. Thank you for your patience and all of your work. This is a really
great patch, and our IR code is MUCH better because of it.
Stephen - I know you've been keeping Congruity in step with Andreas patches,
but now that his patches are actually applied, you may want to make sure it
works with CVS head.
Stephen - you have a patch waiting in the wings - can you send that in now?
Sorry to make you wait so long.
Andreas, I'd like to get a release out with these patches in mid-late
November, and following that release will be a good time to start merging
your pronto stuff.
Everyone - anything at all waiting now should be sent! Unfortunately, I have
a pretty hectic traveling schedule starting this coming week for a few
weeks, but I really want to get back to trying to make firmware work on the
rest of the non-zwave remotes...
> - Checking return codes of functions against LC_OK:
> if (try_something(data) != LC_OK) {...)
> should IMHO also replace the frequent:
> if (try_something(data)) { /* failed */...'
> to make the code more readable.
I think the later is fine, honestly. It's pretty standard in the open source
world.
--
Phil Dibowitz [EMAIL PROTECTED]
Open Source software and tech docs Insanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
"Never write it in C if you can do it in 'awk';
Never do it in 'awk' if 'sed' can handle it;
Never use 'sed' when 'tr' can do the job;
Never invoke 'tr' when 'cat' is sufficient;
Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
