Andreas Schulz wrote: > Phil/Stuart, > > Since I, from the lack of any follow-up messages, had the impression > that my proposed patch for Stuart's problem has failed to attract > public attention in this list (probably because I once again failed to > properly tag it as [patch]), here I try again:
I'm applying the patch. I've made a handful of changes. I made you wait so
long, I figured I'd just do them instead of bouncing it back to you.
In mode_string()
- I changed the casing.
In report_mode_mismatch()
- I took off the "<>" around the mode, switched the wording and the order.
- I also printed the error to stderr, where we print all errors to.
- Added an additional note to try not specifying a file.
In main()
I changed this:
if (mode == MODE_UNSET) {
mode = file_mode;
} else {
if (mode != file_mode){
to the cleaner:
if (mode == MODE_UNSET) {
mode = file_mode;
} else if (mode != file_mode) {
That both collapses the else / if, to else if and adds a missing space.
While I was at it, I fixed all the other places were errors were printed to
stdout. Arguable things aren't 100% consistent because in the main switch,
the "failed to" lines are still stdout, but I see those as the same as the
final "succeeded/failed" message - status, not the actual error. Hmm.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docs Insanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
"Never write it in C if you can do it in 'awk';
Never do it in 'awk' if 'sed' can handle it;
Never use 'sed' when 'tr' can do the job;
Never invoke 'tr' when 'cat' is sufficient;
Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
