I've reviewed the Python bindings and they are up-to-date w.r.t.
libconcord.h, so good for release.
I did find one small bug; patch attached.
Checkin comment:
Prototype lc_strerr (so it returns a pointer-sized value, not an
int-sized value), to avoid either/both incorrect exception text or
crashes on 64-bit machines.
? initialize_write_data.patch
? lc_py_err_str_fix.patch
? concordance/.deps
? concordance/.libs
? concordance/Makefile
? concordance/Makefile.in
? concordance/aclocal.m4
? concordance/autom4te.cache
? concordance/concordance
? concordance/config.guess
? concordance/config.h
? concordance/config.h.in
? concordance/config.log
? concordance/config.status
? concordance/config.sub
? concordance/configure
? concordance/depcomp
? concordance/install-sh
? concordance/libtool
? concordance/ltmain.sh
? concordance/missing
? concordance/stamp-h1
? consnoop/consnoop
? libconcord/.deps
? libconcord/.libs
? libconcord/Makefile
? libconcord/Makefile.in
? libconcord/aclocal.m4
? libconcord/autom4te.cache
? libconcord/binaryfile.lo
? libconcord/config.guess
? libconcord/config.h
? libconcord/config.h.in
? libconcord/config.log
? libconcord/config.status
? libconcord/config.sub
? libconcord/configure
? libconcord/depcomp
? libconcord/install-sh
? libconcord/libconcord.la
? libconcord/libconcord.lo
? libconcord/libtool
? libconcord/libusbhid.lo
? libconcord/ltmain.sh
? libconcord/missing
? libconcord/remote.lo
? libconcord/remote_z.lo
? libconcord/stamp-h1
? libconcord/usblan.lo
? libconcord/web.lo
? libconcord/bindings/python/libconcord.pyc
Index: libconcord/bindings/python/libconcord.py
===================================================================
RCS file: /cvsroot/concordance/concordance/libconcord/bindings/python/libconcord.py,v
retrieving revision 1.4
diff -u -p -r1.4 libconcord.py
--- libconcord/bindings/python/libconcord.py 14 Oct 2008 19:35:01 -0000 1.4
+++ libconcord/bindings/python/libconcord.py 13 Feb 2009 04:00:50 -0000
@@ -74,7 +74,7 @@ class LibConcordException(Exception):
self.func = func
self.result = result
try:
- self.result_str = c_char_p(_dll.lc_strerror(c_int(self.result))).value
+ self.result_str = lc_strerror(self.result)
except:
self.result_str = 'Unknown'
@@ -479,6 +479,13 @@ get_time_timezone = _create_func(
c_char_p
)
+# This is not prototyped using _create_func
+# to avoid error checker and tracing loops etc.
+# const char *lc_strerror(int err);
+lc_strerror = _dll.lc_strerror
+lc_strerror.restype = c_char_p
+lc_strerror.argtypes = (c_int,)
+
# void delete_blob(uint8_t *ptr);
delete_blob = _create_func(
'delete_blob',
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
