On Sun, 15 Jul 2012, Phil Dibowitz wrote:

> The congruity patch...
>
> -version = "15+"
> +version = "16+"
>
> Not that it really matters, but I assume "+" means, "after 15" and the last
> version was 15, right? So that 15+ is what it should be.

Yeah, I think I just blindly bumped up the version number.  It probably 
should be just 15+.

> I notice you've added 'threading' for events, and not that I think it needs to
> be done in this diff, but can we use 'threading' can the 'thread' calls be
> replaced with threading calls? I haven't looked into threading in python at
> all, so a quick scan of the docs seems to imply threading sits on thread and
> provides a higher level/nicer API and thus it seems odd to use both.

Yes, I added threading so I could use the 'events' interface to 
synchronize two threads.  I didn't really look at changing any of the 
other thread code.

> Stephen should probably review this though, since it's his code (I don't 
> have commit access anyway), so I recommend sending this patch directly 
> to him as well.

OK, I'll send it to him.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to