On 01/02/2013 06:24 PM, Scott Talbert wrote: > On Wed, 2 Jan 2013, Phil Dibowitz wrote: > >>>> The parsing patch looks fine, but why are you ignoring INVALID_CONFIG as >>>> an error? >>> >>> Because, with firmware upgrades that are not "direct" (such as with the >>> 688) the config gets erased as part of the firmware upgrade. So after a >>> firmware upgrade, the config will be invalid (and this is expected). >> >> Can you add a comment to that effect? > > Done. >
So this all looks fine but this: - reset_remote(cb, cb_arg); + if ((err = reset_remote(cb, cb_arg))) + return err; I think we did this because some remotes don't reset right and we didn't want to return a failure because of it... we just try to reset them and if they reset great and if not we set the time and move on. Sadly, there's no comment, but I seem to recall that being the case... was there a reason you changed this other than it seeming more correct? -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
