On 01/06/2013 08:33 PM, Scott Talbert wrote:
> On Sun, 6 Jan 2013, Phil Dibowitz wrote:
> 
>> -        cb(LC_CB_STAGE_RESET, 0, 0, 2, LC_CB_COUNTER_TYPE_STEPS, cb_arg);
>> +        cb(LC_CB_STAGE_RESET, 0, 0, 2, LC_CB_COUNTER_TYPE_STEPS,
>> +            cb_arg, NULL);
>>
>> Why the line-wrap here? cb_arg fits in under 80 chars. And same for all the
>> other places you did that.
> 
> OK, I've rechecked my 80-char packing and I think it's optimal now.  :)
> 
>> Also, isn't _report_number_of_stages() no longer used? Does it still need to
>> be there?
> 
> It was still used in a couple of places, but I've gone ahead and removed those
> instances in this rev.

Applied. Thanks for all your work on this!


-- 
Phil Dibowitz                             p...@ipom.com
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Be who you are and say what you feel, because those who mind don't matter
 and those who matter don't mind."
 - Dr. Seuss


Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to