On Tue, 23 Jul 2013, Phil Dibowitz wrote:
> Can you use the format that git expects for format-patch? i.e. a one-line
> title/description followed by two newlines, followed by the longer description
> if necessary? format-patch should then use the first for the subject and the
> rest for the body...
I used git format-patch. The problem was that my commit message was all
in one paragraph, so it came out looking a little weird when it got
emailed.
>> - // usbnet remotes seem to use a more normal byte ordering for serial #'s
>> - if (is_usbnet_remote() || is_mh_remote()) {
>> + // Non-HID remotes seem to use a more normal byte ordering for serial
>> #'s
>> + if (is_z_remote() || is_mh_remote()) {
>
> We had it BACKWARDS and nothing noticed? How did this not break all non-mh
> remotes?
The only thing that was broken before this patch was ZWave-HID. USBNet
counts as a Z remote.
Before Patch:
Wacky Byte Ordering: Pure HID, ZWave-HID
Normal Byte Ordering: USBNet, MH
After Patch:
Wacky Byte Ordering: Pure HID
Normal Byte Ordering: ZWave-HID & USBNet ("Z" remotes), MH
>> //memcpy(data, pkt + 6, len);
>> - memcpy(data, pkt + 1, len + 3);
>> + /*
>> + * pkt[0] is the index of the last byte, which means it is equal to the
>> + * length of the packet minus one byte. We want to copy everything but
>> the
>> + * first byte, so we copy pkt[0] bytes.
>> + */
>> + memcpy(data, pkt + 1, pkt[0]);
>> return 0;
>
> Then we can nuke the calculation of 'len' here, right?
>
> And probably those commented out bits too...
I didn't want to change the behavior of 'len' since it gets returned (but
probably nothing uses it). I didn't touch your commented out code,
either. :-)
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
