This is AWESOME. I like it almost as much as I liked my whitespace cleanup. :)
A few minor comments below. Also, have you tried a zwave remote in Windows? What happens with all the dhcp stuff? My understanding is windows usblan driver handles that inherently? Also, it feels like now that this is built with configure/make/make install, that we can now have INSTALL.windows but split among the projects the way we do for linux and mac. On 09/30/2013 08:15 PM, Scott Talbert wrote: > // Make the socket non-blocking so it doesn't hang on systems that > // don't have a usbnet remote. > - int flags = 0; > fd_set wset; > FD_ZERO(&wset); > FD_SET(sock, &wset); > @@ -110,6 +109,7 @@ int FindUsbLanRemote(void) > return LC_ERROR_OS_NET; > } > #else > + int flags = 0; The #if attached to this #else is a 'WIN32' instead of a '_WIN32' Also, CPP shouldn't be indented... while you're there, can you fix that? > --- a/libconcord/win/libconcord.def > +++ /dev/null FINALLY! WOO. Visual C++ is retarded. > -//User-Agent: HarmonyBrowser/7.7.0 (Build 0; UpdatedFrom 7.3.0.15; Skin > logitech; Windows Vista 6.1; x86; en; rv: 1.8.0.2) Gecko/20060125\r\n\ > - I get a feeling we'll need to start using this soon... it might be nice to leave there in a comment. -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
